Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1741, Remove SB get last message sender info requirement #1742

Merged

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jul 30, 2021

Describe the contribution
Fix #1741, just removes requirement we no longer support (SB Get last message sender)

Testing performed
None, requirements/docs update only

Expected behavior changes
None

System(s) tested on
N/A

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jul 30, 2021
@skliper skliper added this to the 7.0.0 milestone Jul 30, 2021
@astrogeco
Copy link
Contributor

@skliper can I merge this?

@skliper
Copy link
Contributor Author

skliper commented Aug 4, 2021

@skliper can I merge this?

That's like asking me if I want a raise. Yes, I do. J/k... Sure, I'm good w/ it but you (or someone) should probably provide some independence :)

@astrogeco
Copy link
Contributor

CCB:2021-08-04 APPROVED

@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Aug 4, 2021
@astrogeco astrogeco changed the base branch from main to integration-candidate August 4, 2021 16:50
@astrogeco astrogeco merged commit 64f68ea into nasa:integration-candidate Aug 4, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Aug 4, 2021
nasa/cFE#1742, Remove SB get last message sender info requirement

nasa/cFE#1732, Fix #1725 Update UTs to use UtAssert_MIR

nasa/cFE#1736, Add Functional Tests cFE Message ID

nasa/cFE#1707, Add Time Conversion Functional Test
astrogeco added a commit to nasa/cFS that referenced this pull request Aug 6, 2021
**Combines**

nasa/cFE#1759, v6.8.0-rc1+dev810
nasa/osal#1126, v5.1.0-rc1+dev586

**Includes**

*cFE*

- nasa/cFE#1752, Add null pointer check to table GetAddresses and ReleaseAddresses
- nasa/cFE#1742, Remove SB get last message sender info requirement
- nasa/cFE#1732, Fix #1725 Update UTs to use UtAssert_MIR
- nasa/cFE#1736, Add Functional Tests cFE Message ID
- nasa/cFE#1707, Add Time Conversion Functional Test
- nasa/cFE#1739, Add cast to MIR prints

*osal*

- nasa/osal#1122, Add UtAssert_MIR macro
- nasa/osal#1125, add generic asserts from CFE coverage testing
- nasa/osal#1121, add osapi-shell-stubs.c to OSAL stub library

Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com>
Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored-by: Alex Campbell <zanzaben@users.noreply.github.com>
Co-authored-by: Jose F Martinez Pedraza <pepepr08@users.noreply.github.com>
Co-authored-by: Niall Mullane <nmullane@users.noreply.github.com>
Co-authored-by: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com>
Co-authored-by: Paul <pavll@users.noreply.github.com>
@skliper skliper deleted the fix1741-rm_get_last_sender_req branch October 22, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove SB: Last Message Sender Info, cSB4309 requirement (removed API)
2 participants