-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming the project name to the name of the containing folder causes make SIMULATION=native prep to fail #709
Comments
It's not finding |
Note the setup steps fail as written (cd example_defs, but you copy it as testcfs_defs). It doesn't look like your build output is from what's described, since testcfs_perfids.h should be a valid name in this case. Can you recreate and confirm there's a real issue, and/or provide setup steps that can recreate the issue? The handful of lines output with |
The reason why the original instructions didn't work is because I'm using a cfs project generation tool for my purposes, and I tried to change the instructions from what I was using for that project to match with what you would expect. I've confirmed the instructions below should work for anyone. I've fixed the instructions for reproducing:
See the attached log for the failing output (hit github max character limit) Immediately after that output, I can bandaid fix the project to prep properly via the following instructions:
The above bandaid results in a successful prep:
|
I'll try to find some time this weekend to look into it, but the starting point is
vs the successful output:
Doesn't seem like cmake is filling ______perfids.h with testcfs when the parent directory is named testcfs. |
I was able to recreate, although not exactly following your example since I'm still a bit confused wrt your setup. It doesn't look like util-linux provides rename on Ubuntu 22.04. Anyways, it comes down to this logic: It should probably only check for a match relative to MISSION_DEFS directory instead of the full path. Or just remove the test, I'm not sure why it needs to be that strict (could still test for something w/ a prefix that matches the relative dir). |
Yeah I'm sorry about the confusion. This issue report was made using ubuntu 22.04, but I no longer have an ubuntu install because I've moved to gentoo. This is why I switched instructions up for rename. I will work on a PR this week. Thanks for helping narrow it down! |
I got the change ready, I'll tag you on it :) |
Fixed via nasa/cFE#2494 |
Checklist (Please check before submitting)
Describe the bug
When creating a new cfs project, if the name of the project folder is the same name as the _defs folder, the
make SIMULATION=native prep
fails.To Reproduce
Steps to reproduce the behavior:
Create a new cfs project (git clone this repo)
Actual behavior
build output
build/CMakeFiles/CMakeOutput.log
Here is the resulting tree:
Expected behavior
The project shouldn't care what the parent directory is named. It should build successfully.
If I change the directory name to anything else, like penguinswearingsunglasses, it runs the prep target fine.
System observed on:
The text was updated successfully, but these errors were encountered: