Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a const global for OS_MAX_API_NAME * 2 and use it #1457

Open
skliper opened this issue Apr 29, 2021 · 0 comments
Open

Define a const global for OS_MAX_API_NAME * 2 and use it #1457

skliper opened this issue Apr 29, 2021 · 0 comments

Comments

@skliper
Copy link
Contributor

skliper commented Apr 29, 2021

Is your feature request related to a problem? Please describe.
Fullname and similar is defined hardcoded as size OS_MAX_API_NAME * 2, example:

char FullName[(OS_MAX_API_NAME * 2)];

Describe the solution you'd like
Create a const global and use it.

Describe alternatives you've considered
May make sense to actually scrub reporting in APIs to use consistent reporting style/technique. Suspect there's either repetition or variation across the services. Candidate for generic utility function - #994

Additional context
Code review. Note FullName in SB is actually appname.taskname.

Requester Info
Jacob Hageman - NASA/GSFC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant