Module list count includes both CFE_PSP_BASE_MODULE_LIST
and the configurable PspModuleList
but some APIs use just the latter.
#319
Labels
bug
Something isn't working
Describe the bug
Both lists are initilized:
PSP/fsw/shared/src/cfe_psp_module.c
Lines 82 to 89 in c3a3f6e
which increments the
CFE_PSP_ModuleCount
:PSP/fsw/shared/src/cfe_psp_module.c
Line 72 in c3a3f6e
but then the API's use
CFE_PSP_ModuleCount
to limit references to just the configurable list (and other related issues):PSP/fsw/shared/src/cfe_psp_module.c
Lines 120 to 142 in c3a3f6e
To Reproduce
For example if there's 1 entry in
CFE_PSP_BASE_MODULE_LIST
and 1 in the additionalPspModuleList
, thenCFE_PSP_ModuleCount
will == 2. Then if you call CFE_PSP_MODULE_FindByName with any module not in thePspModuleList
it'll actually go off the end of thePspModuleList
since it's limited to 2... and it won't find anything in theCFE_PSP_BASE_MODULE_LIST
.Expected behavior
A complete module list should be used for APIs that includes both the built in and added.
Code snips
See above.
System observed on:
N/A - code inspection
Additional context
Stakeholder identified issue
Reporter Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered: