Module list count includes both CFE_PSP_BASE_MODULE_LIST and the configurable PspModuleList but some APIs use just the latter.

[skliper]

Describe the bug
Both lists are initilized:

PSP/fsw/shared/src/cfe_psp_module.c

Lines 82 to 89 in c3a3f6e

	void CFE_PSP_ModuleInit(void)
	{
	/* First initialize the fixed set of modules for this PSP */
	CFE_PSP_ModuleInitList(CFE_PSP_BASE_MODULE_LIST);
	/* Then initialize any user-selected extension modules */
	CFE_PSP_ModuleInitList(GLOBAL_CONFIGDATA.PspModuleList);
	}

which increments the CFE_PSP_ModuleCount:

PSP/fsw/shared/src/cfe_psp_module.c

Line 72 in c3a3f6e

++CFE_PSP_ModuleCount;

but then the API's use CFE_PSP_ModuleCount to limit references to just the configurable list (and other related issues):

PSP/fsw/shared/src/cfe_psp_module.c

Lines 120 to 142 in c3a3f6e

	int32 CFE_PSP_Module_FindByName(const char *ModuleName, uint32 *PspModuleId)
	{
	uint32 i;
	int32 Result;
	CFE_StaticModuleLoadEntry_t *Entry;
	Entry = GLOBAL_CONFIGDATA.PspModuleList;
	Result = CFE_PSP_INVALID_MODULE_NAME;
	i = 0;
	while (i < CFE_PSP_ModuleCount)
	{
	if (strcmp(Entry->Name, ModuleName) == 0)
	{
	*PspModuleId = CFE_PSP_MODULE_BASE | (i & CFE_PSP_MODULE_INDEX_MASK);
	Result = CFE_PSP_SUCCESS;
	break;
	}
	++Entry;
	++i;
	}
	return Result;
	}

To Reproduce
For example if there's 1 entry in CFE_PSP_BASE_MODULE_LIST and 1 in the additional PspModuleList, then CFE_PSP_ModuleCount will == 2. Then if you call CFE_PSP_MODULE_FindByName with any module not in the PspModuleList it'll actually go off the end of the PspModuleList since it's limited to 2... and it won't find anything in the CFE_PSP_BASE_MODULE_LIST.

Expected behavior
A complete module list should be used for APIs that includes both the built in and added.

Code snips
See above.

System observed on:
N/A - code inspection

Additional context
Stakeholder identified issue

Reporter Info
Jacob Hageman - NASA/GSFC

[skliper]

Ping - @superolmo

[jphickey]

Just saw this after I wrote up #353 (duplicate)