Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #117, Replaces strncpy and strlen #119

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Fix #117, Replaces strncpy and strlen #119

merged 1 commit into from
Jul 2, 2024

Conversation

chillfig
Copy link
Contributor

@chillfig chillfig commented Jun 10, 2024 •
edited
Loading

Checklist (Please check before submitting)

Describe the contribution

Testing performed
N/A

Expected behavior changes
N/A

System(s) tested on
N/A

Additional context
Depends on nasa/osal#1465

Third party code
N/A

Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, Vantage Systems

@chillfig chillfig self-assigned this Jun 10, 2024
@chillfig
Copy link
Contributor Author

Add snprintf replacement

@chillfig chillfig changed the title Fix #117, Adds JSC 2.1 Static Analysis comments Fix #117, Replaces strncpy with snprintf Jun 14, 2024
@chillfig
Copy link
Contributor Author

Add snprintf replacement

Edit: snprintf has been added

@chillfig chillfig force-pushed the SA_jsc2_1 branch 3 times, most recently from 23e2ba1 to 4e7796a Compare June 18, 2024 18:07
@chillfig chillfig changed the title Fix #117, Replaces strncpy with snprintf Fix #117, Replaces strncpy and strlen Jun 18, 2024
@chillfig chillfig mentioned this pull request Jun 24, 2024
Closed
2 tasks
Fix nasa#117, Replaces strncpy and strlen
f664494 
This commit addresses issues flagged during static analysis by:
- Replacing strncpy with snprintf to enhance safety and compliance.
- Replacing strlen with OS_strnlen.
@dzbaker
Copy link
Contributor

dzbaker commented Jun 27, 2024

CCB 27 June 2024: Will re-run workflows once osal#1465 is merged in to verify they pass.

@dzbaker dzbaker merged commit 1f8e29a into nasa:main Jul 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chillfig chillfig

Labels
bug CCB:Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Static Code Analysis JSC 2.1
2 participants
@chillfig @dzbaker