Fix #105, Remove 'dummy' from variable names #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
thnkslprpt
force-pushed
the
fix-105-remove-dummy-in-variable-names
branch
from
e722d9e
to
2074282
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Fixes #105
Resubmission of #367
Somehow I tied myself in a few knots trying to squash the merge commit and some clang-format corrections into a single commit.
Anyway, this new PR is from an updated branch so there should be no merge commits I believe.
Removed (unnecessary) use of 'dummy' in several variable names and corresponding function names for completeness - e.g.
cf_config_table_tests_set_table_to_nominal()). NoteDummy_CF_TsnChanAction_fn_t()left as is due to conflicting type defined with the exact same name as this function.Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully (except cppcheck convert to sarif issue - already documented here: nasa/cFS#657)
Expected behavior changes
None
Contributor Info
Avi Weiss @thnkslprpt