This repository has been archived by the owner on Oct 19, 2022. It is now read-only.
fix: make mss abortable #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows passing an options object to `dialer.select` that can contain an `AbortSignal` that will throw if the operation is aborted due to a timeout or other criteria. Also adds types.
achingbrain
requested review from
vasco-santos and
jacobheun
and removed request for
vasco-santos
jacobheun
approved these changes
Dec 21, 2021
| - run: npm install | ||
| - run: npm run lint | ||
| - run: npm run build | ||
| - run: npm run dep-check |
There was a problem hiding this comment.
Not in the package scripts, was previously run via aegir. CI is failing due to this.
| @@ -164,13 +164,14 @@ A new multistream select dialer instance. | |||
| const dialer = new MSS.Dialer(duplex) | |||
| ``` | |||
|
|
|||
| ### `dialer.select(protocols)` | |||
| ### `dialer.select(protocols, [options])` | |||
There was a problem hiding this comment.
This was added to other API methods, those should get updated in the readme as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows passing an options object to
dialer.selectthat can contain anAbortSignalthat will throw if the operation is aborted due to a timeout or other criteria.Also adds types and swaps travis for gh actions.
BREAKING CHANGE: This module now has types