fix: dont mutate select protocols (#55)

multiformats · Oct 31, 2019 · 662b5fd · 662b5fd
1 parent 1877dcf
commit 662b5fd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/select.js b/src/select.js
@@ -6,7 +6,7 @@ const multistream = require('./multistream')
 const handshake = require('it-handshake')
 
 module.exports = async (stream, protocols, protocolId) => {
-  protocols = Array.isArray(protocols) ? protocols : [protocols]
+  protocols = Array.isArray(protocols) ? [...protocols] : [protocols]
   const { reader, writer, rest, stream: shakeStream } = handshake(stream)
 
   const protocol = protocols.shift()

diff --git a/test/dialer.spec.js b/test/dialer.spec.js
@@ -83,6 +83,7 @@ describe('Dialer', () => {
 
       const mss = new MSS.Dialer(duplex)
       const selection = await mss.select(protocols)
+      expect(protocols).to.have.length(2)
       expect(selection.protocol).to.equal(selectedProtocol)
 
       // Ensure stream is usable after selection