Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

[RFC] Client generates wrong authorization URL if base URL contains query parameters #144

Closed
jbaron-gingco opened this issue Jun 4, 2020 · 1 comment · Fixed by #153 or #156
Closed
Assignees
Labels

Comments

@jbaron-gingco
Copy link

if my authorization URL is something like https://example.com/foo?bar=qux, the generated authorization URL is something like https://example.com/foo?bar=qux?client_id=.... But RFC 6749 requires the URL parameters to be kept:

The endpoint URI MAY include an "application/x-www-form-urlencoded"
formatted (per Appendix B) query component ([RFC3986] Section 3.4),
which MUST be retained when adding additional query parameters. The
endpoint URI MUST NOT include a fragment component.

@postatum
Copy link
Contributor

Hi @jbaron-gingco.

Thanks for reporting this issue. I've created a PR to fix it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants