From 68526f706dd7b402787819c30eb20ba4b2837d52 Mon Sep 17 00:00:00 2001 From: Olivier Tassinari Date: Sun, 15 Mar 2020 00:56:33 +0100 Subject: [PATCH 1/3] [Skeleton] Improve wave dark mode support --- packages/material-ui-lab/src/Skeleton/Skeleton.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/material-ui-lab/src/Skeleton/Skeleton.js b/packages/material-ui-lab/src/Skeleton/Skeleton.js index b5d15cf92cf956..dd9aa6e71eb66d 100644 --- a/packages/material-ui-lab/src/Skeleton/Skeleton.js +++ b/packages/material-ui-lab/src/Skeleton/Skeleton.js @@ -49,7 +49,7 @@ export const styles = theme => ({ overflow: 'hidden', '&::after': { animation: '$wave 1.6s linear 0.5s infinite', - background: 'linear-gradient(90deg, transparent, rgba(255, 255, 255, 0.7), transparent)', + background: `linear-gradient(90deg, transparent, ${theme.palette.action.hover}, transparent)`, content: '""', position: 'absolute', transform: 'translateX(-100%)', // Avoid flash during server-side hydration From a530f7f2d11c0836dadd01d6d89deda410c527e4 Mon Sep 17 00:00:00 2001 From: Olivier Tassinari Date: Sun, 15 Mar 2020 13:04:19 +0100 Subject: [PATCH 2/3] increase contrast --- packages/material-ui-lab/src/Skeleton/Skeleton.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/material-ui-lab/src/Skeleton/Skeleton.js b/packages/material-ui-lab/src/Skeleton/Skeleton.js index dd9aa6e71eb66d..016f88713064d8 100644 --- a/packages/material-ui-lab/src/Skeleton/Skeleton.js +++ b/packages/material-ui-lab/src/Skeleton/Skeleton.js @@ -49,7 +49,7 @@ export const styles = theme => ({ overflow: 'hidden', '&::after': { animation: '$wave 1.6s linear 0.5s infinite', - background: `linear-gradient(90deg, transparent, ${theme.palette.action.hover}, transparent)`, + background: `linear-gradient(90deg, transparent, ${theme.palette.action.selected}, transparent)`, content: '""', position: 'absolute', transform: 'translateX(-100%)', // Avoid flash during server-side hydration From e97ff401dfba9b207aba38a02fb16581ebf0b5de Mon Sep 17 00:00:00 2001 From: Olivier Tassinari Date: Sun, 15 Mar 2020 13:14:47 +0100 Subject: [PATCH 3/3] Revert "increase contrast" This reverts commit a530f7f2d11c0836dadd01d6d89deda410c527e4. --- packages/material-ui-lab/src/Skeleton/Skeleton.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/material-ui-lab/src/Skeleton/Skeleton.js b/packages/material-ui-lab/src/Skeleton/Skeleton.js index 016f88713064d8..dd9aa6e71eb66d 100644 --- a/packages/material-ui-lab/src/Skeleton/Skeleton.js +++ b/packages/material-ui-lab/src/Skeleton/Skeleton.js @@ -49,7 +49,7 @@ export const styles = theme => ({ overflow: 'hidden', '&::after': { animation: '$wave 1.6s linear 0.5s infinite', - background: `linear-gradient(90deg, transparent, ${theme.palette.action.selected}, transparent)`, + background: `linear-gradient(90deg, transparent, ${theme.palette.action.hover}, transparent)`, content: '""', position: 'absolute', transform: 'translateX(-100%)', // Avoid flash during server-side hydration