Artifacts method on build endpoint #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 24, 2014 16:50
| end | ||
|
|
||
| it 'returns all artifacts for build' do | ||
| res.body.should be_an_instance_of(Array) |
There was a problem hiding this comment.
This test should be updated to test something meaningful such as making expectations on the artifacts for a build.
|
@mtchavez All updated; the VCR cassette now returns 2 build artifacts, I've added Yardoc and removed the version bump. |
|
Yeah this looks good and the test is a little more meaningful, thanks. |
mtchavez
added a commit
that referenced
this pull request
Jan 29, 2014
Artifacts method on build endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new method to the build class to display of artifact data.
Included updated docs, specs and VCR cassette.