Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nvcc cubin,fatbin,optix-ir compilation mode support #1872

Merged

Conversation

robertmaynard
Copy link
Collaborator

These compilation modes have different output from the compiler but the same input. So we add the compilation mode flag to the common_args when it doesn't match the default mode ( -c )

These compilation modes have different output from the compiler
but the same input. So we add the compilation mode flag to
the `common_args` when it doesn't match the default mode ( -c )
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: +0.56% 🎉

Comparison is base (7074753) 29.46% compared to head (813f4cc) 30.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1872      +/-   ##
==========================================
+ Coverage   29.46%   30.02%   +0.56%     
==========================================
  Files          49       49              
  Lines       17844    17544     -300     
  Branches     8631     8410     -221     
==========================================
+ Hits         5257     5267      +10     
+ Misses       7347     7213     -134     
+ Partials     5240     5064     -176     
Files Changed Coverage Δ
src/compiler/nvcc.rs 42.54% <60.00%> (+6.09%) ⬆️

... and 33 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre sylvestre merged commit b1b005a into mozilla:main Sep 7, 2023
37 of 39 checks passed
@robertmaynard robertmaynard deleted the fea/support_nvcc_other_output_types branch September 11, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants