Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sccache fails to build on non x86_64/aarch64 arches #1866

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

Firstyear
Copy link
Contributor

On all arches except x86_64/aarch64 sccache fails to build. This is due to the use of rustls/ring as a feature in trust-dns-resolver.

However, trust dns resolver isn't actually needed when you set --no-default-features, since this appears to only be to coerce features in trust-dns-resolver when reqwest is present.

As a result, trust-dns-resolver should be optional and only added when required.

On all arches except x86_64/aarch64 sccache fails to build. This is
due to the use of rustls/ring as a feature in trust-dns-resolver.

However, trust dns resolver isn't actually needed when you set
--no-default-features, since this appears to only be to coerce
features in trust-dns-resolver when reqwest is present.

As a result, trust-dns-resolver should be optional and only added
when required.
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.08% 🎉

Comparison is base (7074753) 29.46% compared to head (8c19bb9) 29.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1866      +/-   ##
==========================================
+ Coverage   29.46%   29.55%   +0.08%     
==========================================
  Files          49       49              
  Lines       17844    17844              
  Branches     8631     8631              
==========================================
+ Hits         5257     5273      +16     
- Misses       7347     7350       +3     
+ Partials     5240     5221      -19     

see 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre sylvestre merged commit 92038f4 into mozilla:main Sep 7, 2023
36 of 39 checks passed
@Firstyear Firstyear deleted the ring-fails branch September 7, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants