Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No padding between the "unpublished" tag and the rest of the tags #480

Closed
madalincm opened this issue Aug 1, 2018 · 6 comments
Closed

No padding between the "unpublished" tag and the rest of the tags #480

madalincm opened this issue Aug 1, 2018 · 6 comments
Labels
bug merge upstream verified fixed
Milestone
19

Comments

@madalincm
Copy link

Steps to Reproduce:

  1. Open all queries page and click on the "rrrrrr" tag
  2. Observe the query tags

Expected results:

There are no display or layout issues.

Actual results:

There is no padding between the unpublished tag and the rest of tags

Notes/Issues:

Verified in FF61(Win7). Issue can be reproduced in STMO-stage
Please view this screencast:
paddingtags
@madalincm madalincm added the bug label Aug 1, 2018
@rafrombrc rafrombrc added this to the 16 milestone Aug 1, 2018
@rafrombrc rafrombrc added the ready label Aug 1, 2018
@rafrombrc rafrombrc modified the milestones: 16, 17 Aug 9, 2018
@alison985
Copy link

In seeing if this was still upstream, I found another related issue which is that if you keep adding tags the table of queries expands horizontally behind the right sidebar.
screenshot 2018-09-09 21 59 03

@alison985 alison985 self-assigned this Sep 10, 2018
@alison985 alison985 mentioned this issue Sep 10, 2018
Merged
@alison985
Copy link

PR upstream getredash#2803

@alison985 alison985 added in review in review upstream PR in review in getredash/redash and removed in progress labels Sep 10, 2018
@jezdez
Copy link

jezdez commented Sep 17, 2018

@alison985 This is probably also covered by #476 and getredash#2829

@alison985
Copy link

We're now in this PR from kocsmy getredash#3006

@rafrombrc rafrombrc modified the milestones: 17, 18 Nov 7, 2018
@jezdez
Copy link

jezdez commented Nov 7, 2018

Fixed upstream!

@jezdez jezdez closed this as completed Nov 7, 2018
@jezdez jezdez added merge upstream and removed in review in review upstream PR in review in getredash/redash labels Nov 7, 2018
@jezdez jezdez modified the milestones: 18, 19 Nov 8, 2018
@alison985 alison985 mentioned this issue Nov 11, 2018
Closed
@madalincm
Copy link
Author

The issue is no longer reproducing in STMO-rc
Postfix screenshot:
nopadingfixed

Marking as verified fixed.

@snyk-bot snyk-bot mentioned this issue Jun 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug merge upstream verified fixed
Projects
None yet
Milestone
19
Development

No branches or pull requests
4 participants
@jezdez @rafrombrc @alison985 @madalincm