Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queries are not refreshed at the specific time set in the update schedule #332

Closed
madalincm opened this issue Feb 8, 2018 · 8 comments
Closed
Assignees
Milestone

Comments

@madalincm
Copy link

Steps to Reproduce:

  1. Create a new query and set the refresh schedule to a specific time (i.e: https://pipeline-sql.stage.mozaws.net/queries/315/source)
  2. Wait for the specific time specified in step 1

Expected results:

The query is refreshed at the specified time.

Actual results:

The query is not refreshed at the specified time.

Notes/Issues:

Build identifier: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Verified in FF58(Win7). Issue can be reproduced in STMO-stage and STMO-prod
updateshcedule

@madalincm madalincm added the bug label Feb 8, 2018
@rafrombrc rafrombrc added this to the 14 milestone Feb 21, 2018
@alison985 alison985 self-assigned this May 27, 2018
@alison985
Copy link

@madalincm Can you help me with reproducing this please?

  1. The UI seems to have changed since these screenshots were taken.
  2. I don't know where to find the second page in your screenshot.

Here is what I see: https://www.dropbox.com/s/vviebt5uvm3ou7c/Screenshot%202018-05-27%2009.19.03.png?dl=0 Notice that the refresh schedule is 9:00 and at 9:18 it correctly says refreshed 17 minutes ago.

@alison985
Copy link

@madalincm Just a reminder to see if you can help me with reproducing this please.

@madalincm
Copy link
Author

Sorry for not seeing this issue earlier.
The second page is in here: https://pipeline-sql.stage.mozaws.net/users I only used it to see when was the last time i was active on stmo so that i know how to set the refresh schedule on my query. You do not need that to reproduce the issue.
I'm still able to reproduce the issue using the same steps.
I set the refresh schedule everyday at a given hour for a query but the query is not refreshed when it should.
queries_not_refreshing

@rafrombrc rafrombrc modified the milestones: 14, 15 Jun 20, 2018
@alison985
Copy link

I am not able to reproduce this. Here are the things I tried:

  1. booted up getredash/redash and set a query to update every minute. Monitored http://0.0.0.0:5000/admin/queries/tasks#done for about 10 minutes. There were some 2 minute jumps between created at times, but I figured this could be because of some second issues or the one minute interval being too close together.

  2. booted up Mozilla fork master and did the same query on an update every minute schedule. Again monitored, again saw the 2 minute issue, so I let it run every 5 minutes for. ~3 hours. Those times came out nice and always 5 minutes apart. see here:
    screenshot 2018-06-22 10 34 05

I switched tabs back to the query page and saw that it said it hadn't been updated in 3 hours even though I knew that to be false. I refreshed the page and it said updated as of a few seconds ago. I have now left the query tab open past the 5 minute refresh and it says updated 7 minutes ago even though it ran 2 minutes ago. see here:
screenshot 2018-06-22 10 36 10

I also notice that the last refresh time seems to change, it's counting forward from the last time the page was refreshed.

I really don't think this is an issue or a bug. @jezdez can I close?

@madalincm
Copy link
Author

Thanks @alison985 for investigating on this issue. I tried to isolate my case where I reproduce the issue and I think I am on the right path. I will come with further comments

@madalincm
Copy link
Author

Later Edit:

  1. There is an issue with the time formatting which made me set up my refresh schedules at an incorrect time ergo my queries were not refreshed when I expected. This issue is covered in Inconsistent time formats #441
  2. After removing that factor some of my queries are still not refreshing. After some investigation i have managed to better isolate the scenario. The complete steps to reproduce are here: Queries are not refreshed if the user have not executed them before setting the refresh schedule #442

@alison985
Copy link

Thanks so much @madalincm. I'm closing this issue since #441 and #442 cover it.

@madalincm
Copy link
Author

Marking as a duplcate of #442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants