Improve US subscription state mappings (DENG-2099) #4701
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DENG-2099: Add the geo information(state for US) to the VPN subscription data
The US ZIP codes public data source I started using in #4675 turned out to be missing at least 2,656 ZIP codes (maybe because it was last updated in February 2020?), and unfortunately I haven't been able to find any other good data source for ZIP codes:
This PR instead implements an approach of using ZIP code prefixes which may be less precise in some cases, but will be more comprehensive (4,386 more US subscriptions will get their state location mapped), and hopefully won't be too much hassle to maintain.
Checklist for reviewer:
<username>:<branch>
of the fork as parameter. The parameter will also show upin the logs of the
manual-trigger-required-for-fork
CI task together with more detailed instructions.For modifications to schemas in restricted namespaces (see
CODEOWNERS
):┆Issue is synchronized with this Jira Task