Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FxA custom events to view definition #4483

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Add FxA custom events to view definition #4483

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c6618ca
Add FxA custom events to view definition
akkomar Oct 26, 2023
83566bb
Update sql_generators/event_monitoring/templates/event_monitoring_liv…
scholtzan Oct 26, 2023
31b34b2
Update sql_generators/event_monitoring/templates/event_monitoring_liv…
scholtzan Oct 26, 2023
6b76989
Update sql_generators/event_monitoring/templates/event_monitoring_liv…
scholtzan Oct 26, 2023
7ba095b
Update sql_generators/event_monitoring/templates/event_monitoring_liv…
scholtzan Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion sql_generators/event_monitoring/templates/event_monitoring_live.init.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
OPTIONS
(enable_refresh = TRUE, refresh_interval_minutes = 60)
AS
{% if dataset_id != "telemetry" %}
{% if dataset_id != "telemetry" and dataset_id != "accounts_frontend_live" and dataset_id != "accounts_backend_live" %}
scholtzan marked this conversation as resolved.
Show resolved Hide resolved
SELECT
TIMESTAMP_ADD( TIMESTAMP_TRUNC(TIMESTAMP_ADD(SAFE.PARSE_TIMESTAMP('%FT%H:%M%Ez', ping_info.start_time), INTERVAL event.timestamp MILLISECOND), HOUR),
-- Aggregates event counts over 30-minute intervals
Expand All @@ -25,6 +25,24 @@ FROM
CROSS JOIN
UNNEST(events) AS event,
UNNEST(event.extra) AS event_extra
{% elif dataset_id == "accounts_frontend_live" or dataset_id == "accounts_backend_live" %}
scholtzan marked this conversation as resolved.
Show resolved Hide resolved
-- FxA uses custom pings to send events without a category and extras.
SELECT
TIMESTAMP_ADD(TIMESTAMP_TRUNC(SAFE.PARSE_TIMESTAMP('%FT%H:%M%Ez', ping_info.start_time), HOUR),
-- Aggregates event counts over 30-minute intervals
INTERVAL(DIV(EXTRACT(MINUTE
FROM
SAFE.PARSE_TIMESTAMP('%FT%H:%M%Ez', ping_info.start_time)), 60) * 60) MINUTE) AS window_start,
TIMESTAMP_ADD(TIMESTAMP_TRUNC(SAFE.PARSE_TIMESTAMP('%FT%H:%M%Ez', ping_info.start_time), HOUR), INTERVAL((DIV(EXTRACT(MINUTE
FROM SAFE.PARSE_TIMESTAMP('%FT%H:%M%Ez', ping_info.start_time)), 60) + 1) * 60) MINUTE) AS window_end,
NULL AS event_category,
metrics.string.event_name,
NULL AS event_extra_key,
normalized_channel,
client_info.app_display_version AS VERSION,
COUNT(*) AS total_events
FROM
`{{ project_id }}.{{ dataset_id }}_live.accounts_events_v1`
{% else %}
TIMESTAMP_ADD( TIMESTAMP_TRUNC(TIMESTAMP_ADD(submission_timestamp, INTERVAL event.f0_ MILLISECOND), HOUR),
-- Aggregates event counts over 30-minute intervals
Expand Down