Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DENG-1705 - Add startup_profile_selection_reason_first to clients_daily_v6 #4473

Merged
merged 2 commits into from
Oct 25, 2023
Merged

DENG-1705 - Add startup_profile_selection_reason_first to clients_daily_v6 #4473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62b4263
Add startup_profile_selection_reason to clients-daily-v6
ANich Oct 24, 2023
5d56240
Update schemas
ANich Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sql/moz-fx-data-shared-prod/telemetry_derived/clients_daily_joined_v1/schema.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2336,3 +2336,6 @@ fields:
- name: value
type: INTEGER
mode: NULLABLE
- name: startup_profile_selection_reason_first
type: STRING
mode: NULLABLE
4 changes: 4 additions & 0 deletions sql/moz-fx-data-shared-prod/telemetry_derived/clients_daily_v6/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,7 @@ clients_summary AS (
payload.processes.parent.keyed_scalars.library_opened AS scalar_parent_library_opened,
payload.processes.parent.keyed_scalars.library_search AS scalar_parent_library_search,
payload.processes.parent.scalars.places_previousday_visits AS places_previousday_visits,
payload.processes.parent.scalars.startup_profile_selection_reason AS startup_profile_selection_reason,
-- CAUTION: the order of fields here must match the order defined in
-- count_histograms above and offsets must increment on each line.
count_histograms[OFFSET(0)].histogram AS histogram_parent_devtools_aboutdebugging_opened_count,
Expand Down Expand Up @@ -1424,6 +1425,9 @@ aggregates AS (
ARRAY_AGG(user_pref_browser_urlbar_suggest_bestmatch ORDER BY submission_timestamp DESC)[
OFFSET(0)
] AS user_pref_browser_urlbar_suggest_bestmatch,
ARRAY_AGG(startup_profile_selection_reason ORDER BY submission_timestamp ASC)[
OFFSET(0)
] AS startup_profile_selection_reason_first,
SUM(
scalar_parent_browser_ui_interaction_textrecognition_error
) AS scalar_parent_browser_ui_interaction_textrecognition_error_sum,
Expand Down
3 changes: 3 additions & 0 deletions sql/moz-fx-data-shared-prod/telemetry_derived/clients_daily_v6/schema.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2300,3 +2300,6 @@ fields:
- name: value
type: INTEGER
mode: NULLABLE
- name: startup_profile_selection_reason_first
type: STRING
mode: NULLABLE
6 changes: 6 additions & 0 deletions sql/moz-fx-data-shared-prod/telemetry_derived/clients_first_seen_v1/schema.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,9 @@ fields:
- mode: NULLABLE
name: dltoken
type: STRING
- name: dlsource
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admittedly I don't have lots of context here, but what's this one for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh seems like this was just missed in a previous schema update #4240

type: STRING
mode: NULLABLE
mode: NULLABLE
name: attribution
type: RECORD
Expand Down Expand Up @@ -2299,3 +2302,6 @@ fields:
- name: value
type: INTEGER
mode: NULLABLE
- name: startup_profile_selection_reason_first
type: STRING
mode: NULLABLE
3 changes: 3 additions & 0 deletions sql/moz-fx-data-shared-prod/telemetry_derived/clients_last_seen_v1/schema.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2349,3 +2349,6 @@ fields:
- name: value
type: INTEGER
mode: NULLABLE
- name: startup_profile_selection_reason_first
type: STRING
mode: NULLABLE