Incorporate Curtis' feedback

mozilla · Nov 8, 2023 · f9e137b · f9e137b
1 parent e42dd2a
commit f9e137b
Show file tree

Hide file tree

Showing 10 changed files with 17 additions and 19 deletions.
diff --git a/sql/moz-fx-data-shared-prod/firefox_desktop_derived/review_checker_clients_v1/query.sql b/sql/moz-fx-data-shared-prod/firefox_desktop_derived/review_checker_clients_v1/query.sql
@@ -25,7 +25,7 @@ WITH shopping_metrics AS (
     normalized_country_code,
     sample_id
   FROM
-    `moz-fx-data-shared-prod.firefox_desktop_stable.metrics_v1` AS m
+    `moz-fx-data-shared-prod.firefox_desktop_stable.metrics_v1`
   WHERE
     DATE(submission_timestamp) = @submission_date
   GROUP BY
@@ -116,4 +116,4 @@ joined_data AS (
 SELECT
   *
 FROM
-  joined_data;
+  joined_data
diff --git a/sql/moz-fx-data-shared-prod/firefox_desktop_derived/review_checker_events_v1/metadata.yaml b/sql/moz-fx-data-shared-prod/firefox_desktop_derived/review_checker_events_v1/metadata.yaml
@@ -1,5 +1,7 @@
 friendly_name: Review checker events data
 description: |-
+  The events table includes telemetry related to the review checker sidebar including user
+  interaction with the sidebar, open and closed states, and the status of reviews (stale, unavailable, etc.)
 owners:
 - akommasani@mozilla.com
 - betling@mozilla.com

diff --git a/sql/moz-fx-data-shared-prod/org_mozilla_fenix_derived/review_checker_clients_v1/query.sql b/sql/moz-fx-data-shared-prod/org_mozilla_fenix_derived/review_checker_clients_v1/query.sql
@@ -35,7 +35,7 @@ WITH shopping_metrics AS (
     sample_id,
     ANY_VALUE(ping_info.experiments) AS experiments,
   FROM
-    `moz-fx-data-shared-prod.org_mozilla_fenix_stable.metrics_v1` AS m
+    `moz-fx-data-shared-prod.org_mozilla_fenix_stable.metrics_v1`
   WHERE
     DATE(submission_timestamp) = @submission_date
   GROUP BY
@@ -57,7 +57,7 @@ active AS (
   FROM
     `moz-fx-data-shared-prod.fenix.baseline`
   WHERE
-    DATE(submission_timestamp) > DATE_SUB(CURRENT_DATE(), INTERVAL 2 DAY)
+    DATE(submission_timestamp) = @submission_date
   GROUP BY
     client_info.client_id,
     submission_date
@@ -69,7 +69,7 @@ search AS (
     search_count AS sap,
     ad_click
   FROM
-    `mozdata.search.mobile_search_clients_engines_sources_daily`
+    `moz-fx-data-shared-prod.search.mobile_search_clients_engines_sources_daily`
   WHERE
     submission_date = @submission_date
     AND normalized_app_name = "Fenix"
@@ -104,4 +104,4 @@ joined_data AS (
 SELECT
   *
 FROM
-  joined_data;
+  joined_data
diff --git a/sql/moz-fx-data-shared-prod/org_mozilla_fenix_derived/review_checker_events_v1/metadata.yaml b/sql/moz-fx-data-shared-prod/org_mozilla_fenix_derived/review_checker_events_v1/metadata.yaml
@@ -1,5 +1,7 @@
 friendly_name: Fenix review checker events data
 description: |-
+  The events table includes telemetry related to the review checker sidebar including user
+  interaction with the sidebar, open and closed states, and the status of reviews (stale, unavailable, etc.)
 owners:
 - akommasani@mozilla.com
 - betling@mozilla.com

diff --git a/sql/moz-fx-data-shared-prod/org_mozilla_fenix_derived/review_checker_events_v1/query.sql b/sql/moz-fx-data-shared-prod/org_mozilla_fenix_derived/review_checker_events_v1/query.sql
@@ -6,7 +6,6 @@ SELECT
   MAX(CASE WHEN name = 'address_bar_feature_callout_displayed' THEN 1 ELSE 0 END) is_address_bar_feature_callout_displayed,
   MAX(CASE WHEN name = 'address_bar_icon_clicked' THEN 1 ELSE 0 END) is_address_bar_icon_clicked,
   MAX(CASE WHEN name = 'address_bar_icon_displayed' THEN 1 ELSE 0 END) is_address_bar_icon_displayed,
-  MAX(CASE WHEN name = 'product_page_visits' THEN 1 ELSE 0 END) is_product_page_visits,
   MAX(CASE WHEN name = 'surface_analyze_reviews_none_available_clicked' THEN 1 ELSE 0 END) is_surface_analyze_reviews_none_available_clicked,
   MAX(CASE WHEN name = 'surface_closed' THEN 1 ELSE 0 END) is_surface_closed,
   MAX(CASE WHEN name = 'surface_displayed' THEN 1 ELSE 0 END) is_surface_displayed,

diff --git a/sql/moz-fx-data-shared-prod/org_mozilla_fenix_derived/review_checker_events_v1/schema.yaml b/sql/moz-fx-data-shared-prod/org_mozilla_fenix_derived/review_checker_events_v1/schema.yaml
@@ -20,9 +20,6 @@ fields:
 - name: is_address_bar_icon_displayed
   type: INTEGER
   mode: NULLABLE
-- name: is_product_page_visits
-  type: INTEGER
-  mode: NULLABLE
 - name: is_surface_analyze_reviews_none_available_clicked
   type: INTEGER
   mode: NULLABLE

diff --git a/...z-fx-data-shared-prod/org_mozilla_ios_firefox_derived/review_checker_clients_v1/query.sql b/...z-fx-data-shared-prod/org_mozilla_ios_firefox_derived/review_checker_clients_v1/query.sql
@@ -35,7 +35,7 @@ WITH shopping_metrics AS (
     sample_id,
     ANY_VALUE(ping_info.experiments) AS experiments
   FROM
-    `moz-fx-data-shared-prod.org_mozilla_ios_firefox_stable.metrics_v1` AS m
+    `moz-fx-data-shared-prod.org_mozilla_ios_firefox_stable.metrics_v1`
   WHERE
     DATE(submission_timestamp) = @submission_date
   GROUP BY
@@ -57,7 +57,7 @@ active AS (
   FROM
     `moz-fx-data-shared-prod.firefox_ios.baseline`
   WHERE
-    DATE(submission_timestamp) > DATE_SUB(CURRENT_DATE(), INTERVAL 2 DAY)
+    DATE(submission_timestamp)= @submission_date
   GROUP BY
     client_info.client_id,
     submission_date
@@ -69,11 +69,11 @@ search AS (
     search_count AS sap,
     ad_click
   FROM
-    `mozdata.search.mobile_search_clients_engines_sources_daily`
+    `moz-fx-data-shared-prod.search.mobile_search_clients_engines_sources_daily`
   WHERE
     os = "iOS"
     AND normalized_app_name = "Fennec"
-    AND DATE(submission_date) > DATE_SUB(@submission_date, INTERVAL 2 DAY)
+    AND DATE(submission_date) = @submission_date
 ),
 joined_data AS (
   SELECT
@@ -105,4 +105,4 @@ joined_data AS (
 SELECT
   *
 FROM
-  joined_data;
+  joined_data
diff --git a/...x-data-shared-prod/org_mozilla_ios_firefox_derived/review_checker_events_v1/metadata.yaml b/...x-data-shared-prod/org_mozilla_ios_firefox_derived/review_checker_events_v1/metadata.yaml
@@ -1,5 +1,7 @@
 friendly_name: Firefox iOS review checker events data
 description: |-
+  The events table includes telemetry related to the review checker sidebar including user
+  interaction with the sidebar, open and closed states, and the status of reviews (stale, unavailable, etc.)
 owners:
 - akommasani@mozilla.com
 - betling@mozilla.com

diff --git a/...oz-fx-data-shared-prod/org_mozilla_ios_firefox_derived/review_checker_events_v1/query.sql b/...oz-fx-data-shared-prod/org_mozilla_ios_firefox_derived/review_checker_events_v1/query.sql
@@ -6,7 +6,6 @@ SELECT
   MAX(CASE WHEN name = 'address_bar_feature_callout_displayed' THEN 1 ELSE 0 END) is_address_bar_feature_callout_displayed,
   MAX(CASE WHEN name = 'address_bar_icon_clicked' THEN 1 ELSE 0 END) is_address_bar_icon_clicked,
   MAX(CASE WHEN name = 'address_bar_icon_displayed' THEN 1 ELSE 0 END) is_address_bar_icon_displayed,
-  MAX(CASE WHEN name = 'product_page_visits' THEN 1 ELSE 0 END) is_product_page_visits,
   MAX(CASE WHEN name = 'surface_analyze_reviews_none_available_clicked' THEN 1 ELSE 0 END) is_surface_analyze_reviews_none_available_clicked,
   MAX(CASE WHEN name = 'surface_closed' THEN 1 ELSE 0 END) is_surface_closed,
   MAX(CASE WHEN name = 'surface_displayed' THEN 1 ELSE 0 END) is_surface_displayed,

diff --git a/...-fx-data-shared-prod/org_mozilla_ios_firefox_derived/review_checker_events_v1/schema.yaml b/...-fx-data-shared-prod/org_mozilla_ios_firefox_derived/review_checker_events_v1/schema.yaml
@@ -20,9 +20,6 @@ fields:
 - name: is_address_bar_icon_displayed
   type: INTEGER
   mode: NULLABLE
-- name: is_product_page_visits
-  type: INTEGER
-  mode: NULLABLE
 - name: is_surface_analyze_reviews_none_available_clicked
   type: INTEGER
   mode: NULLABLE