Skip to content

Commit

Permalink
DENG-4847 revert earlier change (#6214)
Browse files Browse the repository at this point in the history
  • Loading branch information
kwindau committed Sep 17, 2024
1 parent 13349e8 commit f57ce59
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,7 @@ def generate_sql(
app_version,
app_build_id,
channel,
{aggregates},
mozfun.stats.mode_last(
ARRAY_AGG(profile_group_id ORDER BY submission_timestamp)
) AS profile_group_id,
{aggregates}
FROM sampled_data
GROUP BY
submission_date,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12920,10 +12920,7 @@ aggregated AS (
'true',
SUM(CASE WHEN payload.processes.parent.scalars.widget_dark_mode = TRUE THEN 1 ELSE 0 END)
)
] AS scalar_aggregates,
mozfun.stats.mode_last(
ARRAY_AGG(profile_group_id ORDER BY submission_timestamp)
) AS profile_group_id,
] AS scalar_aggregates
FROM
sampled_data
GROUP BY
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,3 @@ fields:
mode: REPEATED
name: scalar_aggregates
type: RECORD
- mode: NULLABLE
name: profile_group_id
type: STRING

1 comment on commit f57ce59

@dataops-ci-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration report for "DENG-4847 revert earlier change (#6214)"

sql.diff

Click to expand!
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/clients_daily_scalar_aggregates_v1/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/clients_daily_scalar_aggregates_v1/query.sql
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/clients_daily_scalar_aggregates_v1/query.sql	2024-09-17 19:41:35.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/clients_daily_scalar_aggregates_v1/query.sql	2024-09-17 19:41:27.000000000 +0000
@@ -12920,10 +12920,7 @@
         'true',
         SUM(CASE WHEN payload.processes.parent.scalars.widget_dark_mode = TRUE THEN 1 ELSE 0 END)
       )
-    ] AS scalar_aggregates,
-    mozfun.stats.mode_last(
-      ARRAY_AGG(profile_group_id ORDER BY submission_timestamp)
-    ) AS profile_group_id,
+    ] AS scalar_aggregates
   FROM
     sampled_data
   GROUP BY
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/clients_daily_scalar_aggregates_v1/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/clients_daily_scalar_aggregates_v1/schema.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/clients_daily_scalar_aggregates_v1/schema.yaml	2024-09-17 19:41:35.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/clients_daily_scalar_aggregates_v1/schema.yaml	2024-09-17 19:41:27.000000000 +0000
@@ -42,6 +42,3 @@
   mode: REPEATED
   name: scalar_aggregates
   type: RECORD
-- mode: NULLABLE
-  name: profile_group_id
-  type: STRING
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/clients_daily_scalar_aggregates_v1.sql.py /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/clients_daily_scalar_aggregates_v1.sql.py
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/clients_daily_scalar_aggregates_v1.sql.py	2024-09-17 19:41:35.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/clients_daily_scalar_aggregates_v1.sql.py	2024-09-17 19:41:27.000000000 +0000
@@ -96,10 +96,7 @@
                 app_version,
                 app_build_id,
                 channel,
-                {aggregates},
-                mozfun.stats.mode_last(
-                    ARRAY_AGG(profile_group_id ORDER BY submission_timestamp)
-                ) AS profile_group_id,
+                {aggregates}
             FROM sampled_data
             GROUP BY
                 submission_date,

Link to full diff

Please sign in to comment.