Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add makefile to build without IDE #24

Merged
merged 2 commits into from
Jul 26, 2018

Conversation

rzr
Copy link
Collaborator

@rzr rzr commented Jul 26, 2018

Other examples could follow this pattern

Change-Id: I8070201762351167b030bfba6dba71e207680166
Bug: #21
Signed-off-by: Philippe Coval p.coval@samsung.com

@rzr rzr force-pushed the sandbox/rzr/review/master branch from 96c45e6 to 302fe21 Compare July 26, 2018 14:48
rzr added a commit to TizenTeam/webthing-esp8266 that referenced this pull request Jul 26, 2018
Other examples could follow this pattern

Change-Id: I8070201762351167b030bfba6dba71e207680166
Bug: WebThingsIO#21
Forwarded: WebThingsIO#24
Signed-off-by: Philippe Coval <p.coval@samsung.com>
Makefile Outdated
#!/usr/bin/make -f
# SPDX-License-Identifier: MPL-2.0
#{
# Copyright 2018-present Samsung Electronics France SAS, and other contributors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a lawyer, but I think this repository is copyright Mozilla

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I guess it's easy to change for me, I tend to reuse existing file when creating new ones

Copy link
Contributor

@hobinjk hobinjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see comment about license header

rzr added 2 commits July 26, 2018 17:28
Other examples could follow this pattern

Change-Id: I8070201762351167b030bfba6dba71e207680166
Bug: WebThingsIO#21
Forwarded: WebThingsIO#24
Signed-off-by: Philippe Coval <p.coval@samsung.com>
Change-Id: I35aebb540c72507423456d133e9f0150ff916174
Signed-off-by: Philippe Coval <p.coval@samsung.com>
@rzr rzr force-pushed the sandbox/rzr/review/master branch from 302fe21 to 5c67ea5 Compare July 26, 2018 15:29
@hobinjk
Copy link
Contributor

hobinjk commented Jul 26, 2018

Great, thanks!

@hobinjk hobinjk merged commit 2f1e120 into WebThingsIO:master Jul 26, 2018
hobinjk pushed a commit that referenced this pull request Jul 26, 2018
Other examples could follow this pattern

Change-Id: I8070201762351167b030bfba6dba71e207680166
Bug: #21
Forwarded: #24
Signed-off-by: Philippe Coval <p.coval@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants