Add ColorSensor Capability #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
7dbc2e1
to
d9db5e7
Compare
rzr
added a commit
to TizenTeam/schemas
that referenced
this pull request
Mar 21, 2019
I have used color sensors lately, to display it on dashboard
I had to reuse a ColorController and set property as read only,
even if this work this can be misleading,
because nothing is controllable then.
This makes me think that RO and WO caps could be generalized as:
{type}Sensor and {type}Actuator.
Then maybe this can aligned to W3C's Generic sensors terms.
Forwarded: WebThingsIO#37
Change-Id: Id64f25acdbb45cb5242e6cd0ff00b31aefe84cee
Relate-to: https://www.slideshare.net/rzrfreefr/wotxr20190320rzr
Signed-off-by: Philippe Coval <p.coval@samsung.com>
mrstegeman
suggested changes
Mar 21, 2019
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
d9db5e7
to
7dbc2e1
Compare
rzr
added a commit
to TizenTeam/schemas
that referenced
this pull request
Sep 30, 2019
I have used color sensors lately, to display it on dashboard
I had to reuse a ColorController and set property as read only,
even if this work this can be misleading,
because nothing is controllable then.
This makes me think that RO and WO caps could be generalized as:
{type}Sensor and {type}Actuator
Change-Id: Id64f25acdbb45cb5242e6cd0ff00b31aefe84cee
Relate-to: https://www.slideshare.net/rzrfreefr/wotxr20190320rzr
Forwarded: WebThingsIO#37
Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
7dbc2e1
to
108fef3
Compare
rzr
added a commit
to TizenTeam/schemas
that referenced
this pull request
Oct 24, 2019
I have used color sensors lately, to display it on dashboard
I had to reuse a ColorController and set property as read only,
even if this work this can be misleading,
because nothing is controllable then.
This makes me think that RO and WO caps could be generalized as:
{type}Sensor and {type}Actuator
Change-Id: Id64f25acdbb45cb5242e6cd0ff00b31aefe84cee
Relate-to: https://www.slideshare.net/rzrfreefr/wotxr20190320rzr
Forwarded: WebThingsIO#37
Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
108fef3
to
428a92e
Compare
I have used color sensors lately, to display it on dashboard
I had to reuse a ColorController and set property as read only,
even if this work this can be misleading,
because nothing is controllable then.
This makes me think that RO and WO caps could be generalized as:
{type}Sensor and {type}Actuator
Change-Id: Id64f25acdbb45cb5242e6cd0ff00b31aefe84cee
Relate-to: https://www.slideshare.net/rzrfreefr/wotxr20190320rzr
Forwarded: WebThingsIO#37
Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
428a92e
to
7659bc9
Compare
|
@benfrancis Are you ok with merging this? I have a gateway change ready to go which just shows the ColorControl circle. |
mrstegeman
approved these changes
Nov 7, 2019
benfrancis
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have used color sensors lately, to display it on dashboard
I had to reuse a ColorController and set property as read only,
even if this work this can be misleading,
because nothing is controllable then.
This makes me think that RO and WO caps could be generalized as:
{type}Sensor and {type}Actuator
Change-Id: Id64f25acdbb45cb5242e6cd0ff00b31aefe84cee
Relate-to: https://www.slideshare.net/rzrfreefr/wotxr20190320rzr
Signed-off-by: Philippe Coval p.coval@samsung.com