Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add Dockerfile to rebuild in container #1402

Merged

Conversation

rzr
Copy link
Contributor

@rzr rzr commented Oct 11, 2018

This docker file is a conveinance tool for developers,
for production deployment please consider this project:

https://github.com/mozilla-iot/gateway-docker

Also run-app.sh can be used to start gw,
more changes to come later.

Usage:

docker-compose up

Change-Id: Ia082fdcb1b945645ff5c058760dbefed8843eea8
Signed-off-by: Philippe Coval philippe.coval@osg.samsung.com

@codecov-io
Copy link

codecov-io commented Oct 11, 2018

Codecov Report

Merging #1402 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1402      +/-   ##
==========================================
+ Coverage   74.67%   74.77%   +0.09%     
==========================================
  Files         127      127              
  Lines        6168     6168              
  Branches      861      861              
==========================================
+ Hits         4606     4612       +6     
+ Misses       1379     1374       -5     
+ Partials      183      182       -1
Impacted Files Coverage Δ
src/models/things.js 95.69% <0%> (+1.07%) ⬆️
src/models/thing.js 70.37% <0%> (+1.23%) ⬆️
src/db.js 77.12% <0%> (+1.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1040ab5...796c14e. Read the comment docs.

Dockerfile Outdated
# WARNING: https://github.com/mozilla-iot/gateway-docker

FROM debian:stable
MAINTAINER Philippe Coval (p.coval@samsung.com)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This docker file is a conveinance tool for developers,
for production deployment please consider this project:

https://github.com/mozilla-iot/gateway-docker

Also run-app.sh can be used to start gw,
more changes to come later.

Usage:

    docker-compose up

Forwarded: WebThingsIO#1402
Change-Id: Ia082fdcb1b945645ff5c058760dbefed8843eea8
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
@rzr rzr force-pushed the sandbox/rzr/devel/build/review/master branch from 5764a16 to 796c14e Compare October 13, 2018 15:15
@mrstegeman
Copy link
Contributor

@rzr What's the purpose of this since we already have a full production-ready Docker image?

@rzr
Copy link
Contributor Author

rzr commented Oct 15, 2018

it can be used for testing local changes on a fresh env

@mrstegeman
Copy link
Contributor

It would probably be useful to allow sharing in the ~/.mozilla-iot volume.

@rzr
Copy link
Contributor Author

rzr commented Oct 18, 2018

Actually I prefer to not mix previously used contents, I prefer to start on blank container to make sure everything is reproducible on the current codebase, but I can submit a config sharing change in later commit.

@mrstegeman mrstegeman merged commit c2c5369 into WebThingsIO:master Oct 18, 2018
@ghost ghost removed the review label Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants