refactor!: remove strict/callback mode from Db.collection helper #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emadum
changed the title
emadum
requested review from
a team,
durran,
nbbeeken and
dariakp
and removed request for
a team
emadum
changed the title
…t-collection-option
nbbeeken
requested changes
May 25, 2021
| if (!options) { | ||
| options = {}; | ||
| } else if (typeof options === 'function') { | ||
| throw new TypeError('The callback form of this helper has been removed.'); |
There was a problem hiding this comment.
@dariakp Just making sure we catch this, depending on who merges first this is a new error to convert.
Maybe this is best as a MongoError?
There was a problem hiding this comment.
I think this will likely go in first so I'll make a note to rebase my branch and check for any added TypeError/MongoError
dariakp
reviewed
May 26, 2021
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
Strict mode has been removed from the `Db.collection` helper, as well as the callback argument which was required by strict mode. `Db.createCollection` can be used when a collection needs to be created explicitly. NODE-2752
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strict mode has been removed from the
Db.collectionhelper,as well as the callback argument which was required by strict mode.
Db.createCollectioncan be used when a collection needs to becreated explicitly.
NODE-2752