Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-3309): remove redundant iteration of bulk write result #2815

Merged
merged 5 commits into from
May 25, 2021

Conversation

nbbeeken
Copy link
Contributor

Add caching for getters that build the result object.
Add benchmarking script.
Add unit test for getter caching.

NODE-3309

Add caching for getters that build the result object.
Add benchmarking script.
Add unit test for getter caching.
@nbbeeken nbbeeken requested review from a team, durran, emadum and dariakp and removed request for a team May 24, 2021 21:26
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken merged commit fac9610 into 3.6 May 25, 2021
@nbbeeken nbbeeken deleted the NODE-3309/bulk-getters branch May 25, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants