Fixes #896: Fixing available version retrieval; enabling allowSnapshots #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wSnapshots - Version range should not be specified in the retrieval at all; removed. - If provided, the actual version range restriction should be used, and not the result of the toString() method - Also, allowSnapshots was ignored for the mojo; corrected
|
Also corrected the way how range was interpreted if also a concrete version was passed inside the VersionRange object. |
jarmoniuk
commented
Jan 3, 2023
| @@ -184,7 +185,12 @@ public ArtifactVersions lookupArtifactVersions( | |||
| mavenSession.getRepositorySession(), | |||
| new VersionRangeRequest( | |||
| toArtifact(artifact) | |||
| .setVersion(versionRange != null ? versionRange.toString() : "(,)"), | |||
| .setVersion(ofNullable(versionRange) | |||
| .map(VersionRange::getRestrictions) | |||
There was a problem hiding this comment.
Here we're using the restriction present in the Version range object if it's present instead of the concrete version.
jarmoniuk
commented
Jan 3, 2023
| .withType("pom") | ||
| .build()); | ||
|
|
||
| ArtifactVersion artifactVersion; | ||
| try { | ||
| artifactVersion = findLatestVersion(artifact, versionRange, null, false); | ||
| artifactVersion = findLatestVersion(artifact, null, allowSnapshots, false); |
There was a problem hiding this comment.
We're never actually interested in range-restricted versions; removing.
srowen
pushed a commit
to apache/spark
that referenced
this pull request
Mar 3, 2023
### What changes were proposed in this pull request? This pr aims upgrade `versions-maven-plugin` to 2.15.0 ### Why are the changes needed? New version bring some improvements like: - mojohaus/versions#898 - mojohaus/versions#883 - mojohaus/versions#878 - mojohaus/versions#893 and some bug fix: - mojohaus/versions#901 - mojohaus/versions#897 - mojohaus/versions#891 The full release notes as follows: - https://github.com/mojohaus/versions/releases/tag/2.15.0 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - GA `Dependencies test` should work normally - Manually check `./dev/test-dependencies.sh --replace-manifest`, run successful Closes #40248 from LuciferYang/SPARK-42648. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Sean Owen <srowen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@slawekjaranowski please review