-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run models #14
Comments
Thanks! |
Can you check that outside vae directory there is a data folder with mnist_full.csv? |
There doesn't exist mnist_full.csv in the data directory. Just mnist_test.csv and mnist_train.csv are included in this directory. |
Hmm, Let me try replicating the issue. |
Thanks! |
@kartikdutt18 I do not remember what there was in |
Right, I am facing electricity outage here, Most probably its mnist_train or mnist_all. Once I'm back, I'll try to find out what was there in the file. |
@kartikdutt18 I will handle it, no worries. |
@shrit, Awesome! Thanks a lot |
@kartikdutt18 I open a pull request here mlpack/examples#92 |
Hmm, Let me look into that now. |
Hey @shrit, I just downloaded all the datasets. I also got mnist_full.csv in my datafolder. |
Hmm, are you sure this is not an old one? |
Yeah looks that way. Sorry about that. |
I am able to fix this issue. Another thing is mnist_train has one extra labels column. We also need to drop that. |
@kartikdutt18 You meant the first column as parsed as in this line https://github.com/mlpack/examples/blob/fbce4998c09abe433c42f2e1519df1b9c94aba5f/mnist_simple/mnist_simple.cpp#L76 |
Right this one, Labels are not needed vae so maybe mnist_full was the csv with train without labels. |
@shrit Thanks. terminate called after throwing an instance of 'std::runtime_error' |
@kartikdutt18 Exactly, in this case, I will remove it using Armadillo from inside mnist_vae. |
@sara-hoseininasab, The padding needs to be valid in transposed layer. Earlier I think boost visitors took care of that but now we need to specify it manually. I'll open a PR shortly to fix that. |
@shrit I am completely new in this scope. Could you please tell me how can I remove the first columns of the dataset using armadillo? |
I think you can add the following line :
at line 65. |
It should be added in mnist_vae_cnn.cpp file, am I right? |
Right, To fix that error you need to make the following change :
Replace the similar layers with this one. |
@kartikdutt18 Thank, the previous error has been solved. But I get the new one: |
784x28 is the size of the older mnist_full matrix. |
Right using mnist_full.csv doesn't give this error. |
@kartikdutt18 Any news about the vae? |
In the source of mlpack, the parameter error is fixed. The only error left is segmentation fault. I'll try to find why that happens in the next couple of days. |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍 |
keep open |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍 |
Just wanted to check in @shrit and @kartikdutt18, do you think that we have resolved this issue? Or is there work we still need to do to be able to run these models? |
Hey @rcurtin, There is partial fix made in mlpack/mlpack#2436. However, The VAE Model still segfaults. Since this has more to do with the examples repo, we also have an issue here. |
No problem @kartikdutt18, I just wanted to check if the issue was still relevant. I suppose we should leave it open until mlpack/examples#84 is fixed, then we can propagate that fix to this repository? |
Sure, Sounds good to me. |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍 |
Keep open |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍 |
Closing this issue as it has been resolved by #156 |
How can we run the models?
I want to run vae model but It's not specified how!
The text was updated successfully, but these errors were encountered: