From 4c9b30db675ba3094a733e2691e968b658105334 Mon Sep 17 00:00:00 2001 From: Kang-Hao Kenny Date: Fri, 19 Sep 2014 23:14:37 +0800 Subject: [PATCH] buffer: improve Buffer constructor Increase the performance of new Buffer construction by initializing all properties before SetIndexedPropertiesToExternalArrayData call. Reviewed-by: Trevor Norris --- lib/buffer.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/buffer.js b/lib/buffer.js index bd69a972003..adb551a9e4e 100644 --- a/lib/buffer.js +++ b/lib/buffer.js @@ -66,6 +66,7 @@ function Buffer(subject, encoding) { 'size: 0x' + kMaxLength.toString(16) + ' bytes'); } + this.parent = null; if (this.length <= (Buffer.poolSize >>> 1) && this.length > 0) { if (this.length > poolSize - poolOffset) createPool(); @@ -217,11 +218,6 @@ Buffer.byteLength = function(str, enc) { }; -// pre-set for values that may exist in the future -Buffer.prototype.length = undefined; -Buffer.prototype.parent = undefined; - - // toString(encoding, start=0, end=buffer.length) Buffer.prototype.toString = function(encoding, start, end) { var loweredCase = false;