Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow skipping errors while creating snowball archive #1868

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

harshavardhana
Copy link
Member

No description provided.

Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this could work if the error is on the write side.

However, I don't really like the idea of returning 200, when some of the files haven't been written. It could hide a lot of problems.

@harshavardhana
Copy link
Member Author

However, I don't really like the idea of returning 200, when some of the files haven't been written. It could hide a lot of problems.

it is when you don't care about source data if it's readable or not, very rarely practical but still applicable when you are recovering as much as you can from source to destination.

@klauspost

@klauspost
Copy link
Contributor

@harshavardhana Yes, I see that. I do however think for the majority you want 200 to mean "your files are safe".

Another header? - I don't think modifying the body is an option.

@harshavardhana
Copy link
Member Author

harshavardhana commented Aug 7, 2023

@harshavardhana Yes, I see that. I do however think for the majority you want 200 to mean "your files are safe".

Another header? - I don't think modifying the body is an option.

This is still optional right now default is still to throw errors. It's only useful rarely by some tools such as ziptransfer that I wrote

@klauspost still a problem for you?

@harshavardhana harshavardhana merged commit 11ae9b4 into minio:master Aug 21, 2023
7 checks passed
@harshavardhana harshavardhana deleted the skiperrs branch August 21, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants