Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trunc for stochastic rounding #72

Closed
milankl opened this issue Sep 18, 2023 · 0 comments · Fixed by #73
Closed

trunc for stochastic rounding #72

milankl opened this issue Sep 18, 2023 · 0 comments · Fixed by #73
Labels
enhancement New feature or request

Comments

@milankl
Copy link
Owner

milankl commented Sep 18, 2023 •
edited
Loading

@madnanabid pointed out in SpeedyWeather/SpeedyWeather.jl#388 that trunc(::Type{Int64},::Float32sr) is missing

Base.trunc(::Type{Int64},x::Float32sr) = trunc(Int64,Float32(x))

should be added. Maybe more generally

Base.trunc(T::Type{<:Integer},x::AbstractStochasticFloat) = trunc(T,float(x))

but this would only work once #70 is addressed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Complete restructure milankl/StochasticRounding.jl
1 participant
@milankl