Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support customized process filter when using command:PickProcess in node attach to process debugger #95598

Closed
aprilandjan opened this issue Apr 18, 2020 · 5 comments
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *extension-candidate Issue identified as good extension implementation

Comments

@aprilandjan
Copy link

The vscode debugger provides really convenient configurations when try to debug a node.js process. Recently I'm using Attach to Process with command:PickProcess and it works perfectly. (see https://code.visualstudio.com/docs/nodejs/nodejs-debugging#_attach-to-node-process-action)

The picker command showed all the the other programs that were launched with one of the various forms of --debug or --inspect arguments. However, most of times users have to select the specific one manually because of the others are possibly just distractions.

If there is some configuration which support customizing process filter for available debuggable process list, then we can directly configure which process to be listed; If only one process is matched, attach to it automatically. This might make the debugger task even more convenient.

Is there any way to approach similar purpose, or can we have this feature in future? Thanks!

@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label Apr 20, 2020
@isidorn
Copy link
Contributor

isidorn commented Apr 20, 2020

The pick process command is not in VS Code core, thus forwarding to @weinand and @connor4312 for now

@isidorn isidorn assigned weinand and connor4312 and unassigned isidorn Apr 20, 2020
@weinand
Copy link
Contributor

weinand commented Apr 20, 2020

A configurable process picker is an excellent extension opportunity.

@weinand weinand added the *extension-candidate Issue identified as good extension implementation label Apr 20, 2020
@bergmeister
Copy link

bergmeister commented May 14, 2020

@aprilandjan If you use processName: "ReplaceWithProcessName", then that works. The problem is only when there is more than one process with that name, in that case it gives an error. In my opinion it should just present the picker with the filter already set to ReplaceWithProcessName. I opened #97815 for that, which is a much smaller scoped feature request that does not need an extension.

@aprilandjan
Copy link
Author

aprilandjan commented May 14, 2020

@bergmeister Thanks for your opinion!

I tried processName in my node project, but It seems that the vscode node debugger does not support this processName, maybe it is because that different language debuggers have different configurations?

Back to the topic, what we want are actually the same: define a process filter pattern, and allow manually pick if multiple matched results are founded. Seems that different language debugger must do that separately.

Besides, I found that #50378 might be helpful to implement this(and I'm planning to do it recently 😃).

@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *extension-candidate Issue identified as good extension implementation
Projects
None yet
Development

No branches or pull requests

6 participants
@weinand @isidorn @connor4312 @aprilandjan @bergmeister and others