Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat.Req.: API: showInputBox() user input validation and feedback #1381

Closed
bgse opened this issue Dec 16, 2015 · 2 comments
Closed

Feat.Req.: API: showInputBox() user input validation and feedback #1381

bgse opened this issue Dec 16, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@bgse
Copy link
Contributor

bgse commented Dec 16, 2015

It would be nice if we could validate user input before they dismiss with "ok", i.e. show the user they write something we won't accept before they dismiss the inputbox.

This could be a red outline around the inputbox if value doesnt pass validation, ideally would have a message shown underneath telling them what we expect.

A regex and (optional?) default message could work for many cases, ideally a custom validator that allows us to accept/reject (with optional message?) on user input change.

Possible duplicate of this, but this even goes a little further I think:

#426

@jrieken jrieken added api feature-request Request for new features or functionality labels Dec 16, 2015
@dbaeumer dbaeumer added this to the Backlog milestone Dec 16, 2015
@jrieken jrieken modified the milestones: Jan 2016, Backlog Dec 23, 2015
@jrieken
Copy link
Member

jrieken commented Dec 23, 2015

related to #540.

We could extend the InputBoxOptions to allow to provide a validator

@jrieken jrieken mentioned this issue Jan 5, 2016
5 tasks
@jrieken
Copy link
Member

jrieken commented Jan 5, 2016

this will be handled by #1795

@jrieken jrieken closed this as completed Jan 5, 2016
@egamma egamma removed the feature-request Request for new features or functionality label Jan 6, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants