Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Set Value in debug WATCH view #130170

Closed
2 tasks done
isidorn opened this issue Aug 5, 2021 · 4 comments
Closed
2 tasks done

Test: Set Value in debug WATCH view #130170

isidorn opened this issue Aug 5, 2021 · 4 comments
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Aug 5, 2021

Refs: #124679, #115063

Complexity: 2

Create Issue


Now we support to Set Value of WATCH expressions using the context menu in the WATCH view. Start debugging a simple javascript program and verify:

  • You can Set Value of variables in the VARIABLES view using the context menu and everything works as before
  • You can Set Value of top level watch expressions in the WATCH view using the context menu. Once you set a new value it is properly shown in the WATCH window. In case that variables is in the VARIABLES view make sure it also refreshes there
  • You can Set Value of child elements in the WATCH view.
@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item labels Aug 5, 2021
@isidorn isidorn added this to the August 2021 milestone Aug 5, 2021
@isidorn
Copy link
Contributor Author

isidorn commented Aug 9, 2021

@connor4312 let me know if it is not realistic for js-debug this milestone and in that case I will update the test plan item to use a different debugger.

@hediet
Copy link
Member

hediet commented Aug 24, 2021

I like this feature!

@hediet hediet removed their assignment Aug 24, 2021
@sana-ajani
Copy link
Contributor

Based on #131488, I guess this doesn't work then, right? "Once you set a new value it is properly shown in the WATCH window. In case that variables is in the VARIABLES view make sure it also refreshes there"

@sana-ajani sana-ajani removed their assignment Aug 25, 2021
@connor4312
Copy link
Member

connor4312 commented Aug 25, 2021

Only the display of the variable in the "variables" view is not updated. The variable should be updated in the runtime as it's used in the rest of the program, watch expressions, and the REPL

@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Projects
None yet
Development

No branches or pull requests

5 participants