Debugger Step Over into skipFiles

[re4388]

VS Code Version:

Version: 1.54.1 (user setup)
Commit: f30a9b7
Date: 2021-03-04T22:38:31.419Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Windows_NT x64 10.0.18363

OS Version:

• win10 1909

• Does this issue occur when all extensions are disabled?: Yes

Steps to Reproduce:

1. npm install -g @angular/cli
2. ng new my-dream-app
3. cd my-dream-app
4. ng serve

launch.json setting (both 2 settings are not working)

{
  "version": "0.2.0",
  "configurations": [
    {
      "type": "pwa-chrome",
      "request": "launch",
      "name": "Launch Chrome",
      "url": "http://localhost:4200",
      "webRoot": "${workspaceFolder}",
      "skipFiles": [
        "${workspaceFolder}/node_modules/**/*.js",
        "${workspaceFolder}/lib/**/*.js",
        "<node_internals>/**/*.js"
      ],
    }
  ]
}

{
  "version": "0.2.0",
  "configurations": [
    {
      "type": "pwa-chrome",
      "request": "launch",
      "name": "Launch Chrome",
      "url": "http://localhost:4200",
      "webRoot": "${workspaceFolder}",
      "skipFiles": [
        "${workspaceFolder}/node_modules/**/*.js",
        "${workspaceFolder}/lib/**/*.js",
        "<node_internals>/**/*.js"
      ],
      "sourceMaps": true,
      "sourceMapPathOverrides": {
        "webpack:/*": "${webRoot}/*",
        "/./*": "${webRoot}/*",
        "/src/*": "${webRoot}/*",
        "/*": "*",
        "/./~/*": "${webRoot}/node_modules/*"
      }
    }
  ]
}

5. set breakpoint
   

6. Start debuggining by click the below panel
   

7.Stop at breakpoint

8. After 3 Step Over, we end up in the below screenshot (sometimes, it seems to skip, but sometimes not)
   On the right, we see those files are indeed skipped in the call stack? But the Step Over still stop inside the file.
   

--

I apologize for my mistake if this is more about Angular specific not Vscode, but I think maybe Vscode debugger shall work as well?

[Gorthog]

This is happening to me as well with nodejs backend with typescript.

[Gorthog]

I have a breakpoint that is hit on the call site of an async function, and even though I have all js files added as skipped in launch.json file, when I press F11, debugger goes into the js file - I expect it to jump to line 9 in ts file.

here is the repro https://github.com/sinapis/vscode-118282

[connor4312]

Thank you for the good issue and repro steps! Turn out this bit of functionality never worked as it was intended. This'll be fixed in the nightly build.

[roblourens]

I press F11 and go into the promise helper in index.js, seems like both smartStep and skipFiles should avoid that

[connor4312]

@roblourens can you share steps? I don't repro this https://memes.peet.io/img/21-04-ed599b74-21dd-48ae-8928-dbb50e256b9d.mp4

[roblourens]

I was using the https://github.com/sinapis/vscode-118282 test repo, not the OP

[connor4312]

That was actually a separate issue that affected attach without an --inspect-brk. If we parsed all scripts before the query for built-in modules returned and never parsed any additional scripts afterwards, skipfiles would never be sent.