Exclude fragments from urlFilter matching

[yrtimiD]

Attach to chrome with remote debug fails without any error message since code 1.51.1. In 1.50 all worked fine.
Chrome version is latest 57.0.4280.66, started with --remote-debugging-port=9222 and inspector is available from other chrome on http://localhost:9222/

To Reproduce

1. use linked launch.json
2. start chrome with --remote-debugging-port=9222
3. Code -> Run -> select "Attach to Chrome" -> click play button

in 1.50 debugger toolbar appears and "Call stack" is populated with available pages,
in 1.51.1 debugger toolbar appears without "disconnect" button, and nothing in "Call Stack"

Log File
launch.json and debugadapter.json

VS Code Version: 1.51.1

Additional context
"Launch in chrome" still works perfectly.

[connor4312]

Can you try with the nightly build? I think the changes in #834 should fix this. In 1.50 (or maybe 1.49, I forget) we briefly introduced a change that made this work, but rolled it back with https://github.com/microsoft/vscode-chrome-debug/issues/719#issuecomment-705072583; the fix in 834 is the correct solution.

[connor4312]

Actually, I think it will still not work. Basically you want the url to actually be exactly http://localhost/#, or alternatively specify a urlFilter like http://localhost/*. We can probably ignore url fragments when matching debug urls.

[yrtimiD]

@connor4312 , specifying "url" exactly as in browser made it work. In my case it was "url": "http://localhost/#".
Adding "urlFilter": "http://localhost/*" instead of url also fixes the issue.

[connor4312]

Actually I realized I already fixed this in #840. It's been released as of VS Code 1.52.