Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not copy "serverReadyAction" property for integrated terminals #814

Closed
weinand opened this issue Oct 22, 2020 · 2 comments
Closed

Do not copy "serverReadyAction" property for integrated terminals #814

weinand opened this issue Oct 22, 2020 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@weinand
Copy link

weinand commented Oct 22, 2020

Do not copy "serverReadyAction" property for integrated terminals

@roblourens
Copy link
Member

I can't create a codespace for the original reported repo, I get an error

ERROR: for codespaces-compose_node_1 Cannot create container for service node: conflicting options: host type networking can't be used with links. This would result in undefined behavior

Can you explain what I need to verify this?

@roblourens roblourens added the verification-steps-needed Steps to verify are needed for verification label Oct 29, 2020
@connor4312
Copy link
Member

Steps:

  1. Use the server ready action tutorial https://code.visualstudio.com/docs/editor/debugging#_automatically-open-a-uri-when-debugging-a-server-program
  2. Running it, the webpage should open once
  3. Add console: "integratedTerminal" to the launch config
  4. Run it again and verify that the webpage still only opens once

@connor4312 connor4312 removed the verification-steps-needed Steps to verify are needed for verification label Oct 29, 2020
@weinand weinand added the verified Verification succeeded label Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants