-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch browser with argument user-data-dir specified without directory junction. #1656
Conversation
try { | ||
fs.mkdirSync(this.storagePath); | ||
} catch (e) {} | ||
if (!fs.existsSync(this.storagePath)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The if
checks should not be necessary for recursive mkdirSync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, I have confirmed by testing that error EEXIST
can be thrown by mkdirSync
only when not recursive,
so existsSync
is unnecessary.
That commit has been amended.
… NOT work if USER_DATA_DIR comes as or with any parent as directory junction, which may fail Microsoft Edge DevTools.
Belated thanks for the PR! Unfortunately release notes have already been cut for this iteration, but you'll be in the "thank you" section in the next release at the end of this month / beginning of next |
It fixes #1633 on OS Windows, let me know if there is some introduced impact not taken into my account, for example some unanticipated side effect on OS other than Windows.