From e3d71b56908509e4165e4916a3118adc99064def Mon Sep 17 00:00:00 2001 From: Don-Vito Date: Sun, 11 Oct 2020 16:18:12 +0300 Subject: [PATCH] 7571: do not activate island windows upon updating position --- src/cascadia/WindowsTerminal/IslandWindow.cpp | 8 ++++---- src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/cascadia/WindowsTerminal/IslandWindow.cpp b/src/cascadia/WindowsTerminal/IslandWindow.cpp index 4312fb59df8..34dc72d85ac 100644 --- a/src/cascadia/WindowsTerminal/IslandWindow.cpp +++ b/src/cascadia/WindowsTerminal/IslandWindow.cpp @@ -263,7 +263,7 @@ void IslandWindow::Initialize() void IslandWindow::OnSize(const UINT width, const UINT height) { // update the interop window size - SetWindowPos(_interopWindowHandle, nullptr, 0, 0, width, height, SWP_SHOWWINDOW); + SetWindowPos(_interopWindowHandle, nullptr, 0, 0, width, height, SWP_SHOWWINDOW | SWP_NOACTIVATE); if (_rootGrid) { @@ -499,7 +499,7 @@ void IslandWindow::SetAlwaysOnTop(const bool alwaysOnTop) 0, 0, 0, - SWP_NOMOVE | SWP_NOSIZE); + SWP_NOMOVE | SWP_NOSIZE | SWP_NOACTIVATE); } } @@ -613,7 +613,7 @@ void IslandWindow::_SetIsBorderless(const bool borderlessEnabled) windowPos.top(), windowPos.width(), windowPos.height(), - SWP_SHOWWINDOW | SWP_FRAMECHANGED); + SWP_SHOWWINDOW | SWP_FRAMECHANGED | SWP_NOACTIVATE); } // Method Description: @@ -699,7 +699,7 @@ void IslandWindow::_ApplyWindowSize() newSize.top, newSize.right - newSize.left, newSize.bottom - newSize.top, - SWP_FRAMECHANGED)); + SWP_FRAMECHANGED | SWP_NOACTIVATE)); } DEFINE_EVENT(IslandWindow, DragRegionClicked, _DragRegionClickedHandlers, winrt::delegate<>); diff --git a/src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp b/src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp index d8e67e7dec7..17491b15ad1 100644 --- a/src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp +++ b/src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp @@ -370,7 +370,7 @@ void NonClientIslandWindow::_UpdateIslandPosition(const UINT windowWidth, const newIslandPos.Y, windowWidth, windowHeight - topBorderHeight, - SWP_SHOWWINDOW)); + SWP_SHOWWINDOW | SWP_NOACTIVATE)); // This happens when we go from maximized to restored or the opposite // because topBorderHeight changes. @@ -849,7 +849,7 @@ void NonClientIslandWindow::_SetIsBorderless(const bool borderlessEnabled) windowPos.top(), windowPos.width(), windowPos.height(), - SWP_SHOWWINDOW | SWP_FRAMECHANGED); + SWP_SHOWWINDOW | SWP_FRAMECHANGED | SWP_NOACTIVATE); } // Method Description: