From 6bb227a20af72f82b2ae0aed1a789f7fa28a7446 Mon Sep 17 00:00:00 2001 From: Mike Griese Date: Fri, 20 Sep 2019 11:53:43 -0500 Subject: [PATCH 1/2] Enable VT processing by default for conpty --- src/host/srvinit.cpp | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/host/srvinit.cpp b/src/host/srvinit.cpp index fe32f13d245..0b1aab196ad 100644 --- a/src/host/srvinit.cpp +++ b/src/host/srvinit.cpp @@ -139,6 +139,17 @@ static bool s_IsOnDesktop() reg.LoadFromRegistry(Title); } } + else + { + // microsoft/terminal#1965 - Let's just always enable VT processing by + // default for conpty clients. This prevents peculiar differences in + // behavior between conhost and terminal applications when the user has + // VirtualTerminalLevel=1 in their registry. + // We want everone to be using VT by default anyways, so this is a + // strong nudge in that direction. If an application _doesn't_ want VT + // processing, it's free to disable this setting, even in conpty mode. + settings.SetVirtTermLevel(1); + } // 1. The settings we were passed contains STARTUPINFO structure settings to be applied last. settings.ApplyStartupInfo(pStartupSettings); From e9fc3dd47763914c65ccd64f07faa8ac7c9239a2 Mon Sep 17 00:00:00 2001 From: Michael Niksa Date: Mon, 23 Sep 2019 09:26:46 -0700 Subject: [PATCH 2/2] Update src/host/srvinit.cpp Co-Authored-By: Carlos Zamora --- src/host/srvinit.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/host/srvinit.cpp b/src/host/srvinit.cpp index 0b1aab196ad..7c5c7aa6dc4 100644 --- a/src/host/srvinit.cpp +++ b/src/host/srvinit.cpp @@ -145,7 +145,7 @@ static bool s_IsOnDesktop() // default for conpty clients. This prevents peculiar differences in // behavior between conhost and terminal applications when the user has // VirtualTerminalLevel=1 in their registry. - // We want everone to be using VT by default anyways, so this is a + // We want everyone to be using VT by default anyways, so this is a // strong nudge in that direction. If an application _doesn't_ want VT // processing, it's free to disable this setting, even in conpty mode. settings.SetVirtTermLevel(1);