From 36879c1e4d5f6618eba18aea5be8f60a951bea51 Mon Sep 17 00:00:00 2001 From: Mim van den Bos Date: Tue, 20 Jul 2021 21:04:18 +0200 Subject: [PATCH] Add background color to grid to prevent animation overflow (#10716) ## Summary of the Pull Request Add an explicit background color to part of the settings UI to prevent animation overflow. The previous solution (adding a ScrollViewer) caused problems. ## References #10619 adds a ScrollViewer for one of the issues in #10609 ## PR Checklist * [x] Closes #10664 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed Visually confirmed the animation doesn't overflow, changed the theme and confirmed the colors are responsive. Confirmed the extra scrollbar is gone. --- src/cascadia/TerminalSettingsEditor/MainPage.xaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/cascadia/TerminalSettingsEditor/MainPage.xaml b/src/cascadia/TerminalSettingsEditor/MainPage.xaml index 23f66358dc0..83ad8ad9008 100644 --- a/src/cascadia/TerminalSettingsEditor/MainPage.xaml +++ b/src/cascadia/TerminalSettingsEditor/MainPage.xaml @@ -116,11 +116,12 @@ - - - + +