-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(har timing): record connect
timing for proxied connections
#32855
base: main
Are you sure you want to change the base?
Conversation
connect
timing for proxied connections
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Max Schmitt <max@schmitt.mx> Signed-off-by: Simon Knott <info@simonknott.de>
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"1 flaky36416 passed, 757 skipped Merge workflow run. |
Do we have to upgrade the deps? I am always wary of introducing regressions. |
For SOCKS proxy we don't, but for HTTP proxy yes. The If we don't want to update, another alternative would be leave things as for the HTTP proxy and set |
Fixes a bug discovered in #32647. When using http proxy, the
connect
event isn't emitted so we don't populatetcpConnectionAt
. The updated version ofhttps-proxy-agent
emits aproxyConnect
as a replacement, so this PR updates and listens to that event.For socks proxies, the
on("socket")
event is emitted once the SOCKS connection is established, which is the equivalent of having a TCP connection available.