Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: brush up fixtures, unflake some tests #32854

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Sep 27, 2024

No description provided.

server.setRoute('/target.html', async (req, res) => {
res.end('<html><title>Served by the proxy</title></html>');
});
const port = 9339 + testInfo.workerIndex;
const browserServer = await browserType.launch({
args: ['--remote-debugging-port=' + port, ...(process.platform === 'win32' ? ['--proxy-server=some-value'] : [])]
args: ['--remote-debugging-port=' + port]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did you spot this one? curious.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was looking for process.platform.

Copy link
Contributor

Test results for "tests 1"

2 flaky ⚠️ [playwright-test] › ui-mode-test-setup.spec.ts:98:5 › should show errors in config
⚠️ [playwright-test] › ui-mode-test-setup.spec.ts:22:5 › should run global setup and teardown

36403 passed, 757 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit 5947c21 into microsoft:main Sep 27, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants