fix: input events triggered by playwright actions should have composed=true #28730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
yury-s
force-pushed
the
select-composed
branch
from
e1ead2c
to
a0f5b75
Compare
yury-s
changed the title
yury-s
commented
Dec 21, 2023
| @@ -732,7 +732,7 @@ export class InjectedScript { | |||
| if (element.nodeName.toLowerCase() === 'input') { | |||
| const input = element as HTMLInputElement; | |||
| const type = input.type.toLowerCase(); | |||
| const kInputTypesToSetValue = new Set(['color', 'date', 'time', 'datetime', 'datetime-local', 'month', 'range', 'week']); | |||
There was a problem hiding this comment.
There is no such input type as 'datetime'.
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Dec 21, 2023
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"5 flaky21251 passed, 569 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28726