fix(locator): locator(locator) method uses internal:chain instead of >>
#24235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of `>>`
Usually, we can just chain two locators with `>>` to implement `Locator.locator()`.
However, this does not play nicely with more advanced inner locators like `or` and `and`:
```ts
const child = page.locator('input').or(page.locator('button'));
page.locator('parent').locator(child);
```
One could expect the above to locate "input or button" inside a "parent".
However, currently it locates "input inside a parent" or "button".
To fix this, we have to wrap inner locator into `internal:chain` and
query it separately from the parent.
pavelfeldman
approved these changes
Jul 14, 2023
Germandrummer92
pushed a commit
to OctoMind-dev/playwright
that referenced
this pull request
Oct 27, 2023
… of `>>` (microsoft#24235) Usually, we can just chain two locators with `>>` to implement `Locator.locator(locator)`. However, this does not play nicely with more advanced inner locators like `or` and `and`: ```ts const child = page.locator('input').or(page.locator('button')); page.locator('parent').locator(child); ``` One would expect the above to locate "input or button" inside a "parent". However, currently it locates "input inside a parent" or "button", because it's translated to `parent >> input >> internal:or="button"`. To fix this, we have to wrap inner locator into `internal:chain` and query it separately from the parent. Fixes microsoft#23724.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually, we can just chain two locators with
>>to implementLocator.locator(locator). However, this does not play nicely with more advanced inner locators likeorandand:One would expect the above to locate "input or button" inside a "parent". However, currently it locates "input inside a parent" or "button", because it's translated to
parent >> input >> internal:or="button".To fix this, we have to wrap inner locator into
internal:chainand query it separately from the parent.Fixes #23724.