From 6a598aaaa5c2ad22b7f0c323ae17a3e35a6e4a7c Mon Sep 17 00:00:00 2001 From: Victoria Dye Date: Thu, 2 Dec 2021 14:50:05 -0500 Subject: [PATCH] release: include GIT_BUILT_FROM_COMMIT in MacOS build Set the `GIT_BUILT_FROM_COMMIT` based on the version specified in the `make dist` output archive header. This ensures the commit hash is shown in `git version --build-options`. Signed-off-by: Victoria Dye --- .github/macos-installer/Makefile | 2 +- .github/workflows/build-git-installers.yml | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/macos-installer/Makefile b/.github/macos-installer/Makefile index 39837650ae2929..df339bd921df23 100644 --- a/.github/macos-installer/Makefile +++ b/.github/macos-installer/Makefile @@ -21,7 +21,7 @@ BUILD_CODE := intel-$(ARCH_CODE) BUILD_DIR := $(GITHUB_WORKSPACE)/payload DESTDIR := $(PWD)/stage/git-$(BUILD_CODE)-$(VERSION) ARTIFACTDIR := build_artifacts -SUBMAKE := $(MAKE) C_INCLUDE_PATH="$(C_INCLUDE_PATH)" CPLUS_INCLUDE_PATH="$(CPLUS_INCLUDE_PATH)" LD_LIBRARY_PATH="$(LD_LIBRARY_PATH)" TARGET_FLAGS="$(TARGET_FLAGS)" CFLAGS="$(CFLAGS)" LDFLAGS="$(LDFLAGS)" NO_GETTEXT=1 NO_DARWIN_PORTS=1 prefix=$(GIT_PREFIX) DESTDIR=$(DESTDIR) +SUBMAKE := $(MAKE) C_INCLUDE_PATH="$(C_INCLUDE_PATH)" CPLUS_INCLUDE_PATH="$(CPLUS_INCLUDE_PATH)" LD_LIBRARY_PATH="$(LD_LIBRARY_PATH)" TARGET_FLAGS="$(TARGET_FLAGS)" CFLAGS="$(CFLAGS)" LDFLAGS="$(LDFLAGS)" NO_GETTEXT=1 NO_DARWIN_PORTS=1 prefix=$(GIT_PREFIX) GIT_BUILT_FROM_COMMIT="$(GIT_BUILT_FROM_COMMIT)" DESTDIR=$(DESTDIR) CORES := $(shell bash -c "sysctl hw.ncpu | awk '{print \$$2}'") .PHONY: image pkg payload diff --git a/.github/workflows/build-git-installers.yml b/.github/workflows/build-git-installers.yml index 6c1ca067f63a26..57f529f3a13457 100644 --- a/.github/workflows/build-git-installers.yml +++ b/.github/workflows/build-git-installers.yml @@ -339,6 +339,9 @@ jobs: echo "${{ needs.prereqs.outputs.tag_version }}" >>git/version make -C git -j$(sysctl -n hw.physicalcpu) GIT-VERSION-FILE dist dist-doc + export GIT_BUILT_FROM_COMMIT=$(gunzip -c git/git-$VERSION.tar.gz | git get-tar-commit-id) || + die "Could not determine commit for build" + # Extract tarballs mkdir payload manpages tar -xvf git/git-$VERSION.tar.gz -C payload