Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restart request should have config argument to check if configuration changed #180

Closed
isidorn opened this issue Mar 9, 2021 · 1 comment
Closed

Restart request should have config argument to check if configuration changed #180

isidorn opened this issue Mar 9, 2021 · 1 comment
Assignees
@weinand
Milestone
April 2021

Comments

@isidorn
Copy link

isidorn commented Mar 9, 2021

Related VS Code issue microsoft/vscode#118196

Today the spec of the DAP restart request doesn't say anything about changed launch configurations.
But we could add an optional config argument to the restart request so that an implementation has easy access to it and can compare it with the current values.
@isidorn isidorn mentioned this issue Mar 9, 2021
Closed
@weinand weinand added this to the March 2021 milestone Mar 10, 2021
@weinand weinand modified the milestones: March 2021, April 2021 Mar 29, 2021
@kieferrm kieferrm mentioned this issue Apr 6, 2021
Closed
75 tasks
@weinand
Copy link
Contributor

weinand commented Apr 14, 2021

The restart request now takes an argument for the "launch" or "attach" configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weinand weinand

Labels
None yet
Projects
None yet
Milestone
April 2021
Development

No branches or pull requests
2 participants
@weinand @isidorn