Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect ignorePatterns in getPackageInfos #773

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ecraig12345
Copy link
Member

#761 added error checking for duplicate package names, which accidentally caused issues in workspace-tools when trying to update beachball (see microsoft/workspace-tools#172 (comment)).

workspace-tools is a single package, but it has some other test fixture monorepos inside it. Because getScopedPackages has to scan for non-workspace monorepos before assuming a single package setup, workspace-tools is getting detected that way and there's an error because several fixture packages share a name.

One way to fix this is to respect the ignorePatterns option when scanning for packages. This adds a bit of cost but is probably the right thing to do, and will likely help avoid other subtle issues in the future with similar fixture setups.

NOTE: The actual fix is simple (in src/monorepo/getPackageInfos.ts) but a LOT of references needed to be updated due to the signature change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant