Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change indentation #941

Closed
Netail opened this issue Feb 19, 2024 · 2 comments
Closed

Change indentation #941

Netail opened this issue Feb 19, 2024 · 2 comments

Comments

@Netail
Copy link

Netail commented Feb 19, 2024

Hi team Beachball,
Would it be possible to change the JSON indentation?
Currently the indentation is set to 2 spaces

fs.writeJSONSync(info.packageJsonPath, packageJson, { spaces: 2 });
but wouldn't be nice to make this an option to e.g. change to 4. Maybe a dynamic indentation; use current indentation if file exists else use root package.json indentation

Context: We use 4 spaces within our company and beachball resets the CHANGELOG.json & package.json formatting to 2 spaces and then our formatters change it to 4 again. And it goes back-and-forth like that :(

@Netail
Copy link
Author

Netail commented Jun 5, 2024

@kenotron @ecraig12345 What you guys think of the related pull request? Something like 'auto' could be added in the future?

@Netail Netail closed this as completed Aug 23, 2024
@Netail Netail reopened this Aug 23, 2024
@Netail
Copy link
Author

Netail commented Aug 23, 2024

Moved back to changeset

@Netail Netail closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant