fix: java.lang.ArrayIndexOutOfBoundsException in multi-node cluster run #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2278 Address the `java.lang.ArrayIndexOutOfBoundsException` error in multi-node cluster runs. * **Error Handling:** - Add error handling for `scoredDataOutPtr` and `scoredDataLengthLongPtr` pointers in the `score`, `predictLeaf`, `featuresShap`, and `innerPredict` methods in `LightGBMBooster.scala`. - Ensure proper deletion of `scoredDataOutPtr` and `scoredDataLengthLongPtr` pointers after use in the `innerPredict` method. * **Testing:** - Add a new test file `LightGBMBoosterTest.scala`. - Add test cases to verify that the `score`, `predictLeaf`, `featuresShap`, and `innerPredict` methods handle `scoredDataOutPtr` and `scoredDataLengthLongPtr` pointers correctly. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/SynapseML/issues/2278?shareId=XXXX-XXXX-XXXX-XXXX).
dciborow
changed the title
dciborow
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2282 +/- ##
===========================================
- Coverage 84.53% 19.62% -64.91%
===========================================
Files 327 295 -32
Lines 16788 14157 -2631
Branches 1500 1287 -213
===========================================
- Hits 14191 2778 -11413
- Misses 2597 11379 +8782 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2278
Address the
java.lang.ArrayIndexOutOfBoundsExceptionerror in multi-node cluster runs.Error Handling:
scoredDataOutPtrandscoredDataLengthLongPtrpointers in thescore,predictLeaf,featuresShap, andinnerPredictmethods inLightGBMBooster.scala.scoredDataOutPtrandscoredDataLengthLongPtrpointers after use in theinnerPredictmethod.Testing:
LightGBMBoosterTest.scala.score,predictLeaf,featuresShap, andinnerPredictmethods handlescoredDataOutPtrandscoredDataLengthLongPtrpointers correctly.For more details, open the Copilot Workspace session.