Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are functions like BatchEncoder::encode or Evaluator::add not const? #333

Closed
AlexanderViand opened this issue May 11, 2021 · 2 comments

Comments

@AlexanderViand
Copy link
Contributor

AlexanderViand commented May 11, 2021

I was surprised to see that functions like BatchEncoder::encode/decode or Evaluator::add aren't declared const. Do some of them actually modify the Encoder/Evaluator object?

If not, I'd be happy to submit a PR where they are all set as const, since the lack of const-ness makes it a bit of a pain to write "nice" code against SEAL that needs to create new ctxts/ptxts.

@AlexanderViand AlexanderViand changed the title Why are functions like BatchEncoder::encode or Encrytor::encrypt not const? Why are functions like BatchEncoder::encode not const? May 11, 2021
@AlexanderViand AlexanderViand changed the title Why are functions like BatchEncoder::encode not const? Why are functions like BatchEncoder::encode or Evaluator::add not const? May 11, 2021
@AlexanderViand
Copy link
Contributor Author

Trying it just now, it seems like adding the const qualifiers does work. Will submit a PR.

@WeiDaiWD
Copy link
Contributor

Thanks, Alex! It will appear in the next release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants